Skip to content

Redirect HTTP traffic to HTTPS#198

Closed
devin-ai-integration[bot] wants to merge 6 commits intomainfrom
devin/1744932718-add-http-https-redirect
Closed

Redirect HTTP traffic to HTTPS#198
devin-ai-integration[bot] wants to merge 6 commits intomainfrom
devin/1744932718-add-http-https-redirect

Conversation

@devin-ai-integration
Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration bot commented Apr 17, 2025

Add HTTP to HTTPS Redirect Rule and Static 503 Response

Changes

  • Added HTTP to HTTPS redirect rule with priority 50 (lower than the forward rule) when certificate_arn is not null
  • Added static 503 response for HTTPS listener when certificate_arn is null with message "certificate not available"

Testing

  • Verified changes with terraform plan
  • Will test redirect functionality using the preview environment link once the PR environment checks workflow completes

Link to Devin run

https://app.devin.ai/sessions/133b9e424fea412b8966196ceabaf7eb

Requested by: Loren Yu (loren@navapbc.com)

Tested with curl against preview environment: curl -I -L http://p-198-app-dev-233775397.us-east-1.elb.amazonaws.com

image

Preview environment for app

♻️ Environment destroyed ♻️

Preview environment for app-rails

♻️ Environment destroyed ♻️

devin-ai-integration bot and others added 2 commits April 17, 2025 23:32
…n certificate is unavailable

Co-Authored-By: Loren Yu <loren@navapbc.com>
Co-Authored-By: Loren Yu <loren@navapbc.com>
@devin-ai-integration
Copy link
Copy Markdown
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

devin-ai-integration bot and others added 3 commits April 17, 2025 23:35
Co-Authored-By: Loren Yu <loren@navapbc.com>
…r with no certificate

Co-Authored-By: Loren Yu <loren@navapbc.com>
Comment thread infra/modules/service/load_balancer.tf Outdated
Co-Authored-By: Loren Yu <loren@navapbc.com>
@lorenyu lorenyu requested a review from coilysiren April 18, 2025 00:01
Copy link
Copy Markdown
Contributor

@coilysiren coilysiren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽!

@lorenyu lorenyu changed the title Add HTTP to HTTPS redirect rule and static 503 response Redirect HTTP traffic to HTTPS Apr 18, 2025
@lorenyu
Copy link
Copy Markdown
Collaborator

lorenyu commented Apr 18, 2025

Done in navapbc/template-infra#925

@lorenyu lorenyu closed this Apr 18, 2025
@lorenyu lorenyu deleted the devin/1744932718-add-http-https-redirect branch April 18, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants